Skip to main content ↑ ↓
QRR: Quick Reply Reposition Started by ahrasis · · Read 12533 times 0 Members and 1 Guest are viewing this topic. previous topic - next topic

QRR: Quick Reply Reposition

QRR: Quick Reply Reposition

- For Elk 1.0x & 1.1x
- Fully Hook.

1. Please do your own backup though every installation is backed up automatically.
2. This mod will re-position your forum quickreply box from its current position to immediately after the last post.
3. Upon its successful installation, go to addons settings page to turn it off or on.
4. You will be redirected there automatically though. ;)
5. Thank you to emanuele for the template layer guide.


Thank you for using/testing it.


Yours friendly,
Abu Fahim Ismail.

BSD License. Feel free to modify accordingly but keep author's link if it is in there somewhere. ;)

 

#Change Logs

@Version 1.0.7
- Restore addon to sources directory.
- Adjust display for both 1.0x and 1.1x.
- White background for quickreply box.
- Move warning to before buttons.
Spoiler (click to show/hide)

Re: [ADDON] QRR - Quick Reply Reposition

Reply #1 –

Your code wouldn't work, the comma is a valid way to concatenate only when you use echo.
In this case you'd have to use parenthesis:
Code: [Select]
	// Show a link to the member's profile.
	$poster_div .= '
								<a class="linklevel1 name"' . (empty($message['member']['id']) ? '' : ' href="' . $scripturl . '?action=profile;u=' . $message['member']['id'] . '"') . '>
									' . $message['member']['name'] . '
								</a>';

That said, I think it is done that way because it seems (at least to me) easier to read than the ternary operator ( xx ? yy : zz ).
It's a bit of repetition, yeah.
Bugs creator.
Features destroyer.
Template killer.

Re: [ADDON] QRR - Quick Reply Reposition

Reply #2 –

So comma is replaced by dot (parenthesis) in this kinda case? Thanks for the tips. I'd better check the attached addon whether it is using comma or dot.

Yeah. It is not broken and need no fixing. Just a little bit longer code and that was it. :)

Edited: The addon correctly used comma following echo.

Re: [ADDON] QRR - Quick Reply Reposition

Reply #3 –

Updated to fully hook version. Change Logs are as follow:


#Change Logs
@Version 1.0.2
- Fix minor css issues.

@Version 1.0.1
- Upgraded to fully hook version.

@Version 1.0.0
- Initial release with manual modifications.

Re: [ADDON] QRR - Quick Reply Reposition

Reply #4 –

After install, the avatar is broken in the quick reply area but everything else works fine.

Re: [ADDON] QRR - Quick Reply Reposition

Reply #5 –

Looks good here.

Which file did you use? elk-QRR.hook.v.102.zip or the other? The other is an older version.

@ahrasis as a suggestion, I think you should keep only the most recent version of the addons attached to the messages, otherwise it may become confusing. ;)
Bugs creator.
Features destroyer.
Template killer.

Re: [ADDON] QRR - Quick Reply Reposition

Reply #6 –

I did use elk-QRR.hook.v.102.zip. I also changed some CSS in the poster bit area, do you think that could have affected it?

Re: [ADDON] QRR - Quick Reply Reposition

Reply #7 –

Ok so it turns out it was broken because I had gravatar set as my avatar. I set my avatar to an image from the avatar gallery and it works fine now.

Re: [ADDON] QRR - Quick Reply Reposition

Reply #8 –

I use $context['user']['avatar']['image'] for displaying image in the repositioned quick reply. Somehow, that may not cover gravatar. Can you explain @emanuele ?

Re: [ADDON] QRR - Quick Reply Reposition

Reply #9 –

Looks like a bug with the changes I recently did to the avatars (or maybe not, I didn't investigate much, yet).
I'll track it and try to solve for 1.0.3.

ETA: https://github.com/elkarte/Elkarte/issues/1972
Bugs creator.
Features destroyer.
Template killer.

Re: [ADDON] QRR - Quick Reply Reposition

Reply #11 –

Thank you for the fix @emanuele .

Re: [ADDON] QRR - Quick Reply Reposition

Reply #12 –

Updated...

#Change Logs
@Version 1.0.3
- Improve css and reorganize files.

Re: [ADDON] QRR - Quick Reply Reposition

Reply #13 –

Updated...

#Change Logs

@Version 1.0.4
- Reorganize so that css can be minified together with other css.

Re: [ADDON] QRR - Quick Reply Reposition

Reply #14 –

#Change Logs

@Version 1.0.5
- Resruture addon's directories and locations.