External Authentication Addon WIP (Updates and Questions)

External Authentication Addon WIP (Updates and Questions) Started by Ant59 · October 23, 2014, 07:57:58 am · Read 19971 times 0 Members and 1 Guest are viewing this topic. previous topic - next topic

Re: How do I add actions?

Reply #15 – October 24, 2014, 11:24:15 am

Next thing: have the user be able to associate and disassociate providers from the account settings page.

I'll leave registration stuff until last since I can then re-use the subs I create for associating.

Not had to touch any of the core Elkarte code yet

Re: How do I add actions?

Reply #16 – October 24, 2014, 11:26:16 am

For anyone interested in how the Xydre theme handles the external logins

Re: External Authentication Addon WIP (Updates and Questions)

Reply #17 – October 24, 2014, 12:27:15 pm

WOW!

emanuele has a new hero. nods

Re: External Authentication Addon WIP (Updates and Questions)

Reply #18 – October 24, 2014, 01:10:41 pm

That is awesome ant59. Just for that, you should get a raise to ant60!

Make this part of core when/if you can guys!

Re: External Authentication Addon WIP (Updates and Questions)

Reply #19 – October 24, 2014, 01:27:11 pm

ROFL @ IchBin

Re: External Authentication Addon WIP (Updates and Questions)

Reply #20 – October 28, 2014, 08:46:45 am

I'm having trouble loading the tempalte for the profile page. I'm getting this:

QuoteAn Error Has Occurred
Unable to load the 'action_profile' template.
Back

for this:

Code: [Select]

public function action_profile()
{
	loadTemplate('Extauth');
}

I've added the link to the profile menu here:

Code: [Select]

'extauth' => array(
	'label' => 'Connected Accounts',
	'file' => 'Extauth.controller.php',
	'controller' => 'Extauth_Controller',
	'function' => 'action_profile',
	'sc' => 'post',
	'token' => 'profile-ea%u',
	'password' => true,
	'permission' => array(
		'own' => array('profile_identity_any', 'profile_identity_own'),
		'any' => array('profile_identity_any'),
	),
),

Not sure what's going wrong. It's as if it's completely ignoring the loadTemplate call.

I have a "Extauth.template.php" file in themes/default/ with a template_main() function that just echoes 'Test'. But it won't show, and instead throws that error.

Re: External Authentication Addon WIP (Updates and Questions)

Reply #21 – October 28, 2014, 09:36:15 am

template_main is "deprecated" in the sense that it's better not to rely on it and always name explicitly the template you want to use using the sub_template index:

Code: [Select]

$context['sub_template'] = 'my_template';

then, the menu template tries to be smart and sets a "default" sub_template to the name of the sub-action, in that case "action_profile", so in your template file you should have:

Code: [Select]

function template_action_profile ()
{

}

That should do the trick.

Re: External Authentication Addon WIP (Updates and Questions)

Reply #22 – October 28, 2014, 09:42:15 am

Awesome! It works

Thank you very much @emanuele. You're an encyclopedia of Elkarte

Re: External Authentication Addon WIP (Updates and Questions)

Reply #23 – October 28, 2014, 09:54:46 am

LOL

For sure I know the bugs I wrote.

Re: External Authentication Addon WIP (Updates and Questions)

Reply #24 – October 28, 2014, 10:28:52 am

A little more progress

Re: External Authentication Addon WIP (Updates and Questions)

Reply #25 – October 28, 2014, 11:56:15 am

Association and disassociation work perfectly on the fly

Re: External Authentication Addon WIP (Updates and Questions)

Reply #26 – October 28, 2014, 12:38:29 pm

Wonderful, I'd love to see that as part of the ElkArte Core, so where's the pull request?

Re: External Authentication Addon WIP (Updates and Questions)

Reply #27 – October 28, 2014, 12:47:09 pm

Haha! I'll release it as an addon first, but I'd have no objection to it being included in the core. I'd prefer it to be optional though, rather than forcibly included for people that don't want to use it as per my suggestion here: http://www.elkarte.net/community/index.php?topic=2155

Re: External Authentication Addon WIP (Updates and Questions)

Reply #28 – October 29, 2014, 08:00:13 am

Got a working registration template. I'll add the provider they're coming from at some point too.

EDIT: I might integrate the provider into the Register button, as with the login buttons (give it colour, icon, etc...).

Re: External Authentication Addon WIP (Updates and Questions)

Reply #29 – October 29, 2014, 08:10:04 am

I rolled with that idea and got this. Pretty happy with it. Now I've got to write the handling action for submitting the form and either registering them or telling them they screwed up (oh joy).

I'm wondering whether I should put it all into a single column though. The agreement requires javascript to scale it's height as-is and I can't think of a CSS-only solution.